Enable output of smoke and dust variables from RRFS #593
Conversation
…ess, and hourly wildfire potential from RRFS.
sorc/ncep_post.fd/INITPOST_NETCDF.f
Outdated
| call read_netcdf_3d_para(ncid2d,im,jm,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, & | ||
| spval,recname(18),extdust(ista_2l,jsta_2l,1),lm) | ||
| call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, & | ||
| spval,recname(19),ebb(ista_2l,jsta_2l)) |
There was a problem hiding this comment.
@EricJames-NOAA Could you move reading ebb and hwp after line 1610? They should be in the block of reading variables from FV3 phy files. Please use the consistent format e.g.
VarName='maxvort02'
call read_netcdf_2d_para(ncid3d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,rel_vort_max(ista_2l,jsta_2l))
There was a problem hiding this comment.
@WenMeng-NOAA thanks for the suggestion, I made this change
sorc/ncep_post.fd/INITPOST_NETCDF.f
Outdated
| taod5503d ( i, j, l) = extsmoke ( i, j, l ) + extdust ( i, j, l ) | ||
| dz = ZINT( i, j, l ) - ZINT( i, j, l+1 ) | ||
| aextc55 ( i, j, l ) = taod5503d ( i, j, l ) / dz | ||
| if(i==im/2.and.j==(jsta+jend)/2)print*,'sample taod5503d= ', & |
There was a problem hiding this comment.
@EricJames-NOAA Could you also add a threshold "debugprint" for these three print statements?
e.g. if(debugprint.and.i==im/2.and.j==(jsta+jend)/2)print*,
|
@EricJames-NOAA There is a bug introduced from your PR #582. Could you add the following fixes in this PR in INITPOST_NETCDF.f as: into |
@WenMeng-NOAA very sorry for the bug! I will put in this fix shortly. Thanks for your other good suggestions too. |
…nts, and bug fix for reading in soil moisture availability.
|
@EricJames-NOAA There is another bug introduced from my PR #589. Would you mind adding the fix in this PR? Thanks! |
…new GRIB2 template for smoke-related fields.
|
@EricJames-NOAA I conducted the UPP standalone test with RRFS data you provided. The results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. Can you verify if my test is consistent with the test from your side? |
|
@WenMeng-NOAA your test results look consistent with mine. Thanks for your test! |
|
@EricJames-NOAA With your latest commit, the changed visibility results in fv3r were reverted. The current model outputs for fv3r do not include extdust and extsmoke. |
|
The UPP RT tests were completed on WCOSS2, Hera and Orion. The new base lines are needed for rap/hrrr, 3drtma with this PR. |
WenMeng-NOAA
added
3DRTMA
Ready for Review
This PR enables output of smoke and dust related variables in RRFS, which is already used in GSL's RRFS-B and at least planned for EMC's RRFS-A.
The code has been tested for GSL's RRFS-B in retrospective mode on Jet.
The regression tests pass except for RAP/HRRR and FV3R:
(1) For RAP/HRRR, it seems the authoritative repository does not have the UPP bug fix put into the realtime systems on 21 Dec 2021: https://www.weather.gov/media/notification/pdf2/scn21-86_rap_and_hrr_smoke_units_change_aab.pdf
This bug fix is needed to make the units consistent with labeling (kg/m3) on the smoke variable for RAP/HRRR. The bug fix is included in this PR.
(2) For FV3R, a new baseline is needed since the inclusion of smoke and dust in UPP will affect the visibility diagnostic. A change in the surface visibility field is the only difference in the current FV3R regression test.